[FIX] Revert index (entity format) definition to be a non-negative number, permitting zero #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheChymera
requested review from
tsalo,
erdalkaraca and
DimitriPapadopoulos
as code owners
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
=======================================
Coverage 87.88% 87.88%
=======================================
Files 14 14
Lines 1279 1279
=======================================
Hits 1124 1124
Misses 155 155 ☔ View full report in Codecov by Sentry. |
effigies
approved these changes
May 1, 2023
effigies
changed the title
Co-authored-by: Christopher J. Markiewicz <[email protected]>
|
@effigies non-negative I think is more accurate. Zero is commonly unsigned, so we can have very esoteric discussions on the issues page about whether or not it's positive :3 |
sappelhoff
approved these changes
May 2, 2023
|
Yes, it should be non-negative. I was pointing to the PR where it was changed to positive, so people could evaluate this fix. |
sappelhoff
requested review from
christinerogers,
ericearl,
Remi-Gau,
rwblair and
bendhouseart
|
can we merge this to make sure it's in 1.9.0 ? :) |
|
Yes. We just have rules for changes to the spec to give people adequate time to comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of previous discussions, including #535
A bit of theoretical background:
More practically, there are a few datasets which include
0values of an index:and supporting this doesn't break or encumber anything (if anything it makes the regex matching marginally shorter).
If we were to explicitly exclude zero, I think ordinal would be a better notion, since zero is clearly what people think of as a valid index when reading the word index — though as explained above, even that is a bit arbitrary. The zeroth (nought) week is a thing at some colleges.
@effigies @yarikoptic